Fixes for clang 5.0 and FreeBSD #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- x86_64 is amd64 on FreeBSD; - libX11 is not in the default linker's default path on FreeBSD; - injectKeyPress takes a number, but NULL was provided. At least in clang++ version 5, NULL is defined as nullptr, not 0. That fails to compile.
|
I this piece was copied from Ogre's CMake or some other project. I haven't used APPLE target for a long time and can't say why it is there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x86_64isamd64on FreeBSD;libX11is not in the default linker's default path on FreeBSD;By the way, why
AND NOT APPLE? What's wrong with using position independent code on macOS?