From 735bde0a432db8c0f546bb7e6fc7230a2bcf1602 Mon Sep 17 00:00:00 2001 From: Oliver Klee Date: Sat, 19 Jun 2021 11:40:47 +0200 Subject: [PATCH] Drop pointless abstract methods Abstract methods that duplicate what already is required by the implementing interface do not add any value. Also add a type annotation to the interface. --- src/Renderable.php | 3 +++ src/Value/Value.php | 4 ---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Renderable.php b/src/Renderable.php index b2cc3467..2f88f3a5 100644 --- a/src/Renderable.php +++ b/src/Renderable.php @@ -4,6 +4,9 @@ interface Renderable { + /** + * @return string + */ public function __toString(); /** diff --git a/src/Value/Value.php b/src/Value/Value.php index 80a6893a..8de17d7d 100644 --- a/src/Value/Value.php +++ b/src/Value/Value.php @@ -151,8 +151,4 @@ public function getLineNo() { return $this->iLineNo; } - - //Methods are commented out because re-declaring them here is a fatal error in PHP < 5.3.9 - //public abstract function __toString(); - //public abstract function render(\Sabberworm\CSS\OutputFormat $oOutputFormat); }