Add PHP CS Fixer to the toolchain #287
Conversation
.gitattributes
Outdated
| /.github/ export-ignore | ||
| /.gitignore export-ignore | ||
| /.phive/ export-ignore | ||
| /.php-cs-fixer.dist.php export-ignore |
There was a problem hiding this comment.
Now would maybe be an appropriate time to group all the config files for checking tools into a common folder so that the root folder doesn’t become a mess.
There was a problem hiding this comment.
There was a problem hiding this comment.
And should we also move the Doxyfile?
There was a problem hiding this comment.
Yes, Doxyfile would be great. I’m on the fence about phpunit.xml. I kinda like the fact that you can just run phpunit without args in the root dir. But I think I like clean dirs even more… WDYT?
There was a problem hiding this comment.
Okay, then I'll move Doxyfile as well. Concerning phpunit.xml: I'd also prefer to keep it in the project root as this makes tool integration a lot easier (e.g., being able to easily run the tests in PhpStorm).
There was a problem hiding this comment.
Concerning the config file move: Done, rebased and repushed.
oliverklee
force-pushed
the
feature/php-cs-fixer
branch
from
9c7baec to
d2e8a11
Compare
This tool will help detect and fix more PSR-12 issues, and it will also help modernize the tests so that it's easier to cover issues found by PHPStan with tests.
oliverklee
force-pushed
the
feature/php-cs-fixer
branch
from
d2e8a11 to
068624d
Compare
2 participants
This tool will help detect and fix more PSR-12 issues, and it will also
help modernize the tests so that it's easier to cover issues found by
PHPStan with tests.