Skip to content

[CLEANUP] rector: Add void to PHPUnit test methods #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024
Merged

[CLEANUP] rector: Add void to PHPUnit test methods #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/CSSList/AtRuleBlockListTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public static function provideSyntacticlyCorrectAtRule(): array
/**
* @test
*/
public function implementsAtRule()
public function implementsAtRule(): void
{
$subject = new AtRuleBlockList('');

Expand All @@ -60,7 +60,7 @@ public function implementsAtRule()
/**
* @test
*/
public function implementsRenderable()
public function implementsRenderable(): void
{
$subject = new AtRuleBlockList('');

Expand All @@ -70,7 +70,7 @@ public function implementsRenderable()
/**
* @test
*/
public function implementsCommentable()
public function implementsCommentable(): void
{
$subject = new AtRuleBlockList('');

Expand All @@ -84,7 +84,7 @@ public function implementsCommentable()
*
* @dataProvider provideMinWidthMediaRule
*/
public function parsesRuleNameOfMediaQueries($css)
public function parsesRuleNameOfMediaQueries($css): void
{
$contents = (new Parser($css))->parse()->getContents();
$atRuleBlockList = $contents[0];
Expand All @@ -99,7 +99,7 @@ public function parsesRuleNameOfMediaQueries($css)
*
* @dataProvider provideMinWidthMediaRule
*/
public function parsesArgumentsOfMediaQueries($css)
public function parsesArgumentsOfMediaQueries($css): void
{
$contents = (new Parser($css))->parse()->getContents();
$atRuleBlockList = $contents[0];
Expand Down
10 changes: 5 additions & 5 deletions tests/CSSList/DocumentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,23 @@ protected function setUp(): void
/**
* @test
*/
public function implementsRenderable()
public function implementsRenderable(): void
{
self::assertInstanceOf(Renderable::class, $this->subject);
}

/**
* @test
*/
public function implementsCommentable()
public function implementsCommentable(): void
{
self::assertInstanceOf(Commentable::class, $this->subject);
}

/**
* @test
*/
public function getContentsInitiallyReturnsEmptyArray()
public function getContentsInitiallyReturnsEmptyArray(): void
{
self::assertSame([], $this->subject->getContents());
}
Expand All @@ -66,7 +66,7 @@ public static function contentsDataProvider()
*
* @dataProvider contentsDataProvider
*/
public function setContentsSetsContents(array $contents)
public function setContentsSetsContents(array $contents): void
{
$this->subject->setContents($contents);

Expand All @@ -76,7 +76,7 @@ public function setContentsSetsContents(array $contents)
/**
* @test
*/
public function setContentsReplacesContentsSetInPreviousCall()
public function setContentsReplacesContentsSetInPreviousCall(): void
{
$contents2 = [new DeclarationBlock()];

Expand Down
6 changes: 3 additions & 3 deletions tests/CSSList/KeyFrameTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,23 @@ protected function setUp(): void
/**
* @test
*/
public function implementsAtRule()
public function implementsAtRule(): void
{
self::assertInstanceOf(AtRule::class, $this->subject);
}

/**
* @test
*/
public function implementsRenderable()
public function implementsRenderable(): void
{
self::assertInstanceOf(Renderable::class, $this->subject);
}

/**
* @test
*/
public function implementsCommentable()
public function implementsCommentable(): void
{
self::assertInstanceOf(Commentable::class, $this->subject);
}
Expand Down
20 changes: 10 additions & 10 deletions tests/Comment/CommentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ final class CommentTest extends TestCase
/**
* @test
*/
public function implementsRenderable()
public function implementsRenderable(): void
{
$subject = new Comment();

Expand All @@ -29,7 +29,7 @@ public function implementsRenderable()
/**
* @test
*/
public function getCommentOnEmptyInstanceReturnsReturnsEmptyString()
public function getCommentOnEmptyInstanceReturnsReturnsEmptyString(): void
{
$subject = new Comment();

Expand All @@ -39,7 +39,7 @@ public function getCommentOnEmptyInstanceReturnsReturnsEmptyString()
/**
* @test
*/
public function getCommentInitiallyReturnsCommentPassedToConstructor()
public function getCommentInitiallyReturnsCommentPassedToConstructor(): void
{
$comment = 'There is no spoon.';
$subject = new Comment($comment);
Expand All @@ -50,7 +50,7 @@ public function getCommentInitiallyReturnsCommentPassedToConstructor()
/**
* @test
*/
public function setCommentSetsComments()
public function setCommentSetsComments(): void
{
$comment = 'There is no spoon.';
$subject = new Comment();
Expand All @@ -63,7 +63,7 @@ public function setCommentSetsComments()
/**
* @test
*/
public function getLineNoOnEmptyInstanceReturnsReturnsZero()
public function getLineNoOnEmptyInstanceReturnsReturnsZero(): void
{
$subject = new Comment();

Expand All @@ -73,7 +73,7 @@ public function getLineNoOnEmptyInstanceReturnsReturnsZero()
/**
* @test
*/
public function getLineNoInitiallyReturnsLineNumberPassedToConstructor()
public function getLineNoInitiallyReturnsLineNumberPassedToConstructor(): void
{
$lineNumber = 42;
$subject = new Comment('', $lineNumber);
Expand All @@ -84,7 +84,7 @@ public function getLineNoInitiallyReturnsLineNumberPassedToConstructor()
/**
* @test
*/
public function toStringRendersCommentEnclosedInCommentDelimiters()
public function toStringRendersCommentEnclosedInCommentDelimiters(): void
{
$comment = 'There is no spoon.';
$subject = new Comment();
Expand All @@ -97,7 +97,7 @@ public function toStringRendersCommentEnclosedInCommentDelimiters()
/**
* @test
*/
public function renderRendersCommentEnclosedInCommentDelimiters()
public function renderRendersCommentEnclosedInCommentDelimiters(): void
{
$comment = 'There is no spoon.';
$subject = new Comment();
Expand All @@ -110,7 +110,7 @@ public function renderRendersCommentEnclosedInCommentDelimiters()
/**
* @test
*/
public function keepCommentsInOutput()
public function keepCommentsInOutput(): void
{
$oCss = TestsParserTest::parsedStructureForFile('comments');
self::assertSame('/** Number 11 **/
Expand Down Expand Up @@ -152,7 +152,7 @@ public function keepCommentsInOutput()
/**
* @test
*/
public function stripCommentsFromOutput()
public function stripCommentsFromOutput(): void
{
$oCss = TestsParserTest::parsedStructureForFile('comments');
self::assertSame('
Expand Down
36 changes: 18 additions & 18 deletions tests/OutputFormatTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ protected function setUp(): void
/**
* @test
*/
public function plain()
public function plain(): void
{
self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
Expand All @@ -64,7 +64,7 @@ public function plain()
/**
* @test
*/
public function compact()
public function compact(): void
{
self::assertSame(
'.main,.test{font:italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background:white;}'
Expand All @@ -76,15 +76,15 @@ public function compact()
/**
* @test
*/
public function pretty()
public function pretty(): void
{
self::assertSame(self::TEST_CSS, $this->oDocument->render(OutputFormat::createPretty()));
}

/**
* @test
*/
public function spaceAfterListArgumentSeparator()
public function spaceAfterListArgumentSeparator(): void
{
self::assertSame(
'.main, .test {font: italic normal bold 16px/ 1.2 '
Expand All @@ -97,7 +97,7 @@ public function spaceAfterListArgumentSeparator()
/**
* @test
*/
public function spaceAfterListArgumentSeparatorComplex()
public function spaceAfterListArgumentSeparatorComplex(): void
{
self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica", Verdana, sans-serif;background: white;}'
Expand All @@ -114,7 +114,7 @@ public function spaceAfterListArgumentSeparatorComplex()
/**
* @test
*/
public function spaceAfterSelectorSeparator()
public function spaceAfterSelectorSeparator(): void
{
self::assertSame(
'.main,
Expand All @@ -127,7 +127,7 @@ public function spaceAfterSelectorSeparator()
/**
* @test
*/
public function stringQuotingType()
public function stringQuotingType(): void
{
self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 \'Helvetica\',Verdana,sans-serif;background: white;}
Expand All @@ -139,7 +139,7 @@ public function stringQuotingType()
/**
* @test
*/
public function rGBHashNotation()
public function rGBHashNotation(): void
{
self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
Expand All @@ -151,7 +151,7 @@ public function rGBHashNotation()
/**
* @test
*/
public function semicolonAfterLastRule()
public function semicolonAfterLastRule(): void
{
self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white}
Expand All @@ -163,7 +163,7 @@ public function semicolonAfterLastRule()
/**
* @test
*/
public function spaceAfterRuleName()
public function spaceAfterRuleName(): void
{
self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
Expand All @@ -175,7 +175,7 @@ public function spaceAfterRuleName()
/**
* @test
*/
public function spaceRules()
public function spaceRules(): void
{
self::assertSame('.main, .test {
font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;
Expand All @@ -191,7 +191,7 @@ public function spaceRules()
/**
* @test
*/
public function spaceBlocks()
public function spaceBlocks(): void
{
self::assertSame('
.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
Expand All @@ -204,7 +204,7 @@ public function spaceBlocks()
/**
* @test
*/
public function spaceBoth()
public function spaceBoth(): void
{
self::assertSame('
.main, .test {
Expand All @@ -224,7 +224,7 @@ public function spaceBoth()
/**
* @test
*/
public function spaceBetweenBlocks()
public function spaceBetweenBlocks(): void
{
self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}'
Expand All @@ -236,7 +236,7 @@ public function spaceBetweenBlocks()
/**
* @test
*/
public function indentation()
public function indentation(): void
{
self::assertSame('
.main, .test {
Expand All @@ -259,7 +259,7 @@ public function indentation()
/**
* @test
*/
public function spaceBeforeBraces()
public function spaceBeforeBraces(): void
{
self::assertSame(
'.main, .test{font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
Expand All @@ -271,7 +271,7 @@ public function spaceBeforeBraces()
/**
* @test
*/
public function ignoreExceptionsOff()
public function ignoreExceptionsOff(): void
{
$this->expectException(OutputException::class);

Expand All @@ -290,7 +290,7 @@ public function ignoreExceptionsOff()
/**
* @test
*/
public function ignoreExceptionsOn()
public function ignoreExceptionsOn(): void
{
$aBlocks = $this->oDocument->getAllDeclarationBlocks();
$oFirstBlock = $aBlocks[0];
Expand Down
Loading