Skip to content

[TASK] Remove another PHP-8-only setting from the PHP-CS-Fixer config #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2024
Merged

[TASK] Remove another PHP-8-only setting from the PHP-CS-Fixer config #629

merged 1 commit into from
Jun 30, 2024

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Jun 29, 2024

No description provided.

@oliverklee oliverklee requested review from JakeQZ and sabberworm June 29, 2024 07:59
@oliverklee oliverklee self-assigned this Jun 29, 2024
@oliverklee oliverklee mentioned this pull request Jun 29, 2024
Merged
JakeQZ
JakeQZ approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I found this post-review after approving #592. After some disentangling, it seems the new PHP-CS-Fixer includes an updated PER-CS2.0 ruleset that is incompatible with PHP7 (including 7.4).

@JakeQZ JakeQZ merged commit 27aa880 into main Jun 30, 2024
@JakeQZ JakeQZ deleted the task/remove-match-in-cs branch June 30, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels

None yet

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

3 participants

@oliverklee @JakeQZ