New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino resources {mrl install dir}/resource/Arduino should be extracted "at least" when the first Arduino is started #106

Closed
supertick opened this Issue Aug 27, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@supertick
Contributor

supertick commented Aug 27, 2017

.. dunno if it should be done for "every" Arduino instance created - really, I guess it should be done for every new version of the jar - but the jar doesn't know the version of the extraction ... Soooooo, the version.txt should be extracted as part of an extraction, and then compared in the next extraction - if they are different then full extraction forced over all files ..

@kwatters

This comment has been minimized.

Show comment
Hide comment
@kwatters

kwatters Aug 27, 2017

Contributor

I think this should happen on the first time you start mrl after a clean download.

Contributor

kwatters commented Aug 27, 2017

I think this should happen on the first time you start mrl after a clean download.

@supertick

This comment has been minimized.

Show comment
Hide comment
@supertick

supertick Aug 27, 2017

Contributor

Simple & effective logic would be :

  • check if version file has been extracted with all other resources
  • if yes - read version - if version == jar version - continue
  • if version file not there or version != jar extract everything
Contributor

supertick commented Aug 27, 2017

Simple & effective logic would be :

  • check if version file has been extracted with all other resources
  • if yes - read version - if version == jar version - continue
  • if version file not there or version != jar extract everything
@kwatters

This comment has been minimized.

Show comment
Hide comment
@kwatters

kwatters Aug 27, 2017

Contributor

aye aye captain. sounds good to me. the real hope is that it's easy for folks to find the mrlcomm.ino ...

Contributor

kwatters commented Aug 27, 2017

aye aye captain. sounds good to me. the real hope is that it's easy for folks to find the mrlcomm.ino ...

@supertick

This comment has been minimized.

Show comment
Hide comment
@supertick

supertick Aug 27, 2017

Contributor

changed commented out Zip.extract to FileIO.extractResources(false) - where it "should" extract on the first time (check's if directory has been created) ...
This is not optimum, but I think it would be an improvement and "good'nuff" for Manticore release .. I'll remove the ticket from the project board if it tests as expected, but keep the ticket open for "version" improvements

Contributor

supertick commented Aug 27, 2017

changed commented out Zip.extract to FileIO.extractResources(false) - where it "should" extract on the first time (check's if directory has been created) ...
This is not optimum, but I think it would be an improvement and "good'nuff" for Manticore release .. I'll remove the ticket from the project board if it tests as expected, but keep the ticket open for "version" improvements

@moz4r

This comment has been minimized.

Show comment
Hide comment
@moz4r

moz4r Aug 27, 2017

Contributor

Guys some time ago I noticed a difference between linux and windows os.
Inside linux , dependencies are extracted at every startup ( like inmoov dependencies from repo )
Inside windows, dependencies extracted only at initial installation or update.
What is normal process ?

Contributor

moz4r commented Aug 27, 2017

Guys some time ago I noticed a difference between linux and windows os.
Inside linux , dependencies are extracted at every startup ( like inmoov dependencies from repo )
Inside windows, dependencies extracted only at initial installation or update.
What is normal process ?

@supertick

This comment has been minimized.

Show comment
Hide comment
@supertick

supertick Aug 27, 2017

Contributor

Haven't tried it on Linux yet .. but one big change was Runtime's extraction was

  1. uncommented (because previously I commented it out - because it was extracting every time on all os's
  2. change the extract from Zip.extract - which does not prevent re-extraction, to FileIO.extractResources(false) which does prevent re-extraction after first time...
Contributor

supertick commented Aug 27, 2017

Haven't tried it on Linux yet .. but one big change was Runtime's extraction was

  1. uncommented (because previously I commented it out - because it was extracting every time on all os's
  2. change the extract from Zip.extract - which does not prevent re-extraction, to FileIO.extractResources(false) which does prevent re-extraction after first time...
@supertick

This comment has been minimized.

Show comment
Hide comment
@supertick

supertick Aug 28, 2017

Contributor

I don't think its OS specific moz4r. I believe you had different versions which behaved differently when you tested. I just verified it worky on Linux 64 bit same as it does on Windows 64 bit. It extracts once first time all resources. If resource directory is found, it won't extract again. If resource directory is deleted - then it will extract.

Contributor

supertick commented Aug 28, 2017

I don't think its OS specific moz4r. I believe you had different versions which behaved differently when you tested. I just verified it worky on Linux 64 bit same as it does on Windows 64 bit. It extracts once first time all resources. If resource directory is found, it won't extract again. If resource directory is deleted - then it will extract.

@supertick supertick closed this Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment