MySQLOnRocksDB/mysql-5.6
forked from facebook/mysql-5.6

Loading…
Refine checkpoint logic in MyRocks #114
Closed
yoshinorim opened this Issue
· 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd like checkpoint logic to be refactored as follows.
Rename variable name from rocksdb_snapshot_dir to something like rocksdb_create_checkpoint.
The command creates checkpoint. Something like "create" "checkpoint" sounds better to me.
Return errors to the client if failing to create checkpoint.
Currently the command does not return any error is failing to create checkpoint. This makes debugging hard.
Make it more robust
Currently 'set global rocksdb_snapshot_dir="/data/mysql/backup/snapshot/"; ' command fails but 'set global rocksdb_snapshot_dir="/data/mysql/backup/snapshot"; ' succeeds. The former fails because "Invalid argument: Directory exists". This is a bit confusing and should accept both.
Add more test cases covering the above in rocksdb.checkpoint