Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Clone in Desktop Download ZIP

Loading…

Refine checkpoint logic in MyRocks #114

Closed
yoshinorim opened this Issue · 0 comments

2 participants

@yoshinorim
Owner

I'd like checkpoint logic to be refactored as follows.

  1. Rename variable name from rocksdb_snapshot_dir to something like rocksdb_create_checkpoint.
    The command creates checkpoint. Something like "create" "checkpoint" sounds better to me.

  2. Return errors to the client if failing to create checkpoint.
    Currently the command does not return any error is failing to create checkpoint. This makes debugging hard.

  3. Make it more robust
    Currently 'set global rocksdb_snapshot_dir="/data/mysql/backup/snapshot/"; ' command fails but 'set global rocksdb_snapshot_dir="/data/mysql/backup/snapshot"; ' succeeds. The former fails because "Invalid argument: Directory exists". This is a bit confusing and should accept both.

  4. Add more test cases covering the above in rocksdb.checkpoint

@hermanlee hermanlee referenced this issue in facebook/mysql-5.6
Open

Refine checkpoint logic in MyRocks #63

@hermanlee hermanlee closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.