Address the TODO comment on Table_ddl_manager::put #50

maykov · Apr 2, 2015

This function modifies ddl_hash and index_num_to_keydef.
However, these changes need to be reversed if dict_manager.commit fails
See the discussion here: https://reviews.facebook.net/D35925#inline-259167

yoshinorim · Aug 12, 2015

@maykov Now MyRocks always aborts if dict_manager.commit() fails. Do we still need to fix this?

hermanlee referenced this issue in facebook/mysql-5.6 Sep 28, 2015
Open
Address the TODO comment on Table_ddl_manager::put #33

hermanlee closed this Sep 28, 2015

MySQLOnRocksDB/mysql-5.6 forked from facebook/mysql-5.6

HTTPS clone URL

Subversion checkout URL

Address the TODO comment on Table_ddl_manager::put #50

Labels

Milestone

Assignee

3 participants

Address the TODO comment on Table_ddl_manager::put #33