Skip to content

/mysql-5.6 forked from facebook/mysql-5.6

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Clone in Desktop Download ZIP

Loading…

New issue

Support row checksums #85

Closed
spetrunia opened this Issue · 1 comment

Labels

enhancement

Milestone

  high-pri

Assignee

@spetrunia spetrunia

1 participant

@spetrunia
@spetrunia
Collaborator
spetrunia commented

In order to detect data corruption (from various causes), MyRocks should have an option to store/check checksums of the key/value pairs.

@hermanlee has an experimental patch that was used to catch "prefix key" data corruption.

Checksums should be optional:

  • when checksums are enabled, writes will store the data with checksums, reads will check the checksums, if these are present.
  • when checksums are disabled, writes will store the data without checksums, reads will (Q: or will not?) check the checksums, if they are present.
@spetrunia spetrunia added this to the high-pri milestone
@spetrunia spetrunia self-assigned this
@spetrunia
@spetrunia spetrunia referenced this issue from a commit
@spetrunia spetrunia Issue #85: Support row checksums … 
Summary:
Add support for writing and checking of per-row (and index record) checksums.
Both writing and checking can be dynamically switched on/off via
server variables.

CHECK TABLE will check the checksums for indexes/rows and report the
statistics into the error log.

Based on initial patch by hermanlee4.

Test Plan: Added testcase, ran mtr

Reviewers: maykov, jtolmer, yoshinorim, hermanlee4

Differential Revision: https://reviews.facebook.net/D40911
 6aadc70
@spetrunia spetrunia closed this
@spetrunia spetrunia referenced this issue from a commit
@spetrunia spetrunia Issue #85: Support row checksums … 
Summary:
Add support for writing and checking of per-row (and index record) checksums.
Both writing and checking can be dynamically switched on/off via
server variables.

CHECK TABLE will check the checksums for indexes/rows and report the
statistics into the error log.

Based on initial patch by hermanlee4.

Test Plan: Added testcase, ran mtr

Reviewers: maykov, jtolmer, yoshinorim, hermanlee4

Differential Revision: https://reviews.facebook.net/D40911
 a819b8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.