Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant rewrite of the Picroft documentation for the Raspbian Stretch Lightning version #105

Merged
merged 6 commits into from Jan 4, 2019

Conversation

KathyReid
Copy link
Collaborator

This is a significant rewrite of the Picroft documentation, and "folds in" several pages of documentation to reduce our documentation "surface area", including:

When this PR is merged, several redirects will need to be put in place for these pages so that they don't 404.

In particular, the person who reviews this PR should double check;

  • whether the "sequence" of steps is correct for the Lightning preview
  • whether any of the instructions are incorrect for Lightning preview

Please note that I haven't created a Table of contents using markdown-toc for this page - I am anticipating that there will be edits to this file before it is merged.

@KathyReid KathyReid added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) enhancement labels Dec 27, 2018
@forslund
Copy link
Collaborator

Just starting here but I think in the bluetooth audio section the part about changing the port can be removed. the picroft doesn't launch the Mark-1 enclosure anymore and will not use the port config at all.

@KathyReid
Copy link
Collaborator Author

Thanks for your feedback @forslund - I removed the Bluetooth audio section in one of the commits because I don't think it's relevant any more with the guided setup. Does that make sense?

@forslund
Copy link
Collaborator

Aha, the file preview showed the old file not the new one. Sorry

@KathyReid
Copy link
Collaborator Author

inga problem ;-)

@penrods
Copy link
Collaborator

penrods commented Jan 4, 2019

I've lightly reviewed and will merge it for now, as there are many now-misleading things in the old doc that this certainly corrects. Anything that needs to be altered further can be pulled in with a later PR.

penrods
penrods approved these changes Jan 4, 2019
@penrods penrods merged commit d980537 into master Jan 4, 2019
@penrods penrods deleted the feature/dec2018update/picroft branch January 4, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants