Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix some python2 exclusive code to work also with python3 #11
Conversation
This comment has been minimized.
This comment has been minimized.
|
Hi @antlarr just got round to checking this out and it looks fine. I see you've signed the CLA with your work account but not this account. Could you sign the CLA for this user as well? |
This comment has been minimized.
This comment has been minimized.
|
Sure, I just signed the CLA with this account too. |
This comment has been minimized.
This comment has been minimized.
|
Sorry for the delay, Merging now. |
forslund
merged commit 62e7836
into
MycroftAI:master
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
antlarr commentedFeb 23, 2018
This allows the skill to run under python2 and python3