Czech language: initial support #105
Conversation
devs-mycroft
added
the
CLA: Yes
There was a problem hiding this comment.
Hey Tony, this is fantastic, congratulations on such a huge effort!
I have not yet reviewed this completely, but was taking a quick look through and saw a few things.
There's some files that you probably didn't mean to edit like the travis.yml, example files etc. We'll need to remove those changes from the PR before this could be merged.
Before the final merge, it would also be good to squash some of these commits to keep the commit history clean. If you need some advice on how to do that, please let us know.
Thanks for putting in so much work on this though, it's so great to see more people across the world being able to use Mycroft in their preferred language.
|
yes some help would be good. I replied to all your questions (dont know if i have or not to click on resolve conversation), put all missing files back, but i cant find a way to squash commits. Do I have to close this PR and make a new one with right settings? |
test/test_format.py
Outdated
| @@ -582,7 +582,7 @@ def test_nice_duration(self): | |||
| "thirteen hours fifty three minutes twenty seconds") | |||
| self.assertEqual(nice_duration(50000, speech=False), "13:53:20") | |||
| self.assertEqual(nice_duration(500000), | |||
| "five days eighteen hours fifty three minutes twenty seconds") # nopep8 | |||
| "five days eighteen hours fifty three minutes twenty seconds") # nopep8 | |||
There was a problem hiding this comment.
On the one hand, #nopep8 makes me think this test was meant to verify that nice_duration() works with odd spaces in the input string, so this shouldn't be fixed.
On the other hand, the fact that the tokenizers work is proof positive that whitespace doesn't matter here, so #nopep8 could come out.
Either way, not really relevant to this PR, but it's the kind of thing that linters often catch automatically so you merge it anyway.
There was a problem hiding this comment.
I'd agree on this one. As it's the only test in the file with a #nopep8 flag I think it's intentionally there to test odd spacing.
@Tony763 can you switch this back please?
Whoever merges the PR can squash it at that time. If you'd like to learn about squashing it yourself, it's Regardless, somebody else can take care of it in the GitHub interface. |
Tony763
force-pushed
the
master
branch
3 times, most recently
from
0509001
to
5c2d81f
Compare
|
@ChanceNCounter, @krisgesling - rebased |
|
Do I have to do something more? |
|
Nope, sorry. I was trying to suss out whether that refactor is about to be merged, because it'd make about half this stuff unnecessary, and this would be the easier PR to alter. But it doesn't look like that PR is gonna be merged today or tomorrow, so if nobody else gets to this by the time I'm at a computer (I'm on my phone) I'll re-review and potentially merge. |
|
Well, I've looked it over, and everything seems to be in the right place. You should delete the It also occurs to me that, not speaking Czech, I would have no way of knowing if there's an egregious spelling or grammatical error in there, or even if it's just a bunch of profanity. While you're deleting that .eggfile, we should ask @krisgesling whether Mycroft's had a solution to that in the past. |
Removed, rebased. |
|
Yeah my Czech isn't great either. I kind of expect that something isn't perfect but as you said elsewhere one of the easiest ways to find out is to get it out in peoples hands. Once we have a few Czech speakers using it, any inconsistencies should get flagged pretty quickly. The biggest concern I guess would be someone intentionally adding inappropriate content in another language however they'd be going to a lot of effort for a very small joke, it would also likely get picked up fairly quickly by another speaker of that language, and we don't officially support other languages yet so we're not making any guarantees as to the accuracy of things. I think this is ready to merge as soon as we revert the tiny change on the |
|
Space reverted back. As You say, I know this is imperfect and that is why I named it initial. It will by easier to lure some czech devs or czech/english speaking people that can help with translation of skills. Really only few people want to translate something when they can't use it. And You will be first with working (beta) voice assistant, because none of big players have it (Google, Amazon, Apple) |
|
Wow that is very cool, I didn't realise just how momentous this was! |
|
Also if you'd like a dedicated Czech language channel on Mycroft Chat, please let me know. |
|
Firstly I will send more PRs with finished translations I have made with @Manasovo |
Initial support. All test passed. Will need future improvments.