Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling the pause() function does not pause the playback #1194

Closed
akailash opened this issue Nov 1, 2017 · 2 comments
Closed

Calling the pause() function does not pause the playback #1194

akailash opened this issue Nov 1, 2017 · 2 comments

Comments

@akailash
Copy link

akailash commented Nov 1, 2017

This pause() function does not have the desired effect of pausing the playback.
self.emitter.emit(Message('mycroft.sudio.service.stop'))
This stops the playback, but the Audioservice does not expose a stop function. I could make the commit to add the stop() function if agreed upon.

@forslund
Copy link
Collaborator

forslund commented Nov 1, 2017

The pause method is not supported by all backends, for example mpg123 doesn't support it but if the vlc backend is selected as default it will work. (The vlc backend should be set as default, it's tested well enough now)

Adding stop to the interface is a good idea, I'd be happy to accept a PR with this :)

The stop signal is currently tied to the the global stop (writing stop in cli or pressing the button on top of the mark-1), a message bus mycroft.audio.service.stop exists to handle it so it would be good to have that added to the interface.

akailash pushed a commit to akailash/mycroft-core that referenced this issue Nov 1, 2017
@akailash
Copy link
Author

akailash commented Nov 2, 2017

Thanks for the explanation. I was using mpg123. Please review PR submitted for the stop interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants