Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Dutch language (nl-nl) support #2380

Closed
mikewoudenberg opened this issue Nov 7, 2019 · 6 comments
Closed

Proper Dutch language (nl-nl) support #2380

mikewoudenberg opened this issue Nov 7, 2019 · 6 comments

Comments

@mikewoudenberg
Copy link
Contributor

@mikewoudenberg mikewoudenberg commented Nov 7, 2019

At this moment Mycroft already contains a lot of translations for the Dutch language. It already contains logic for formatting Dutch date, times and numbers. It is however lacking support for parsing Dutch sentences, which causes a number of built in skills to fail because of the unsupported language. I'm working on extending this parse functionality and this issue is to help track efforts in doing so.

@forslund

This comment has been minimized.

Copy link
Member

@forslund forslund commented Nov 7, 2019

Thank you for picking this up and improving the internationalization. Before we can accept your work we need you to sign a CLA. There is some manual intervention needed on our side so you might want to start the processes now. Go to https://mycroft.ai/cla to get going!

Looking forward to seeing your additions!

@krisgesling

This comment has been minimized.

Copy link
Contributor

@krisgesling krisgesling commented Nov 7, 2019

Thanks for your efforts Mike!
If you have any questions, or there are other ways we can help, please let us know :)

@j1nx

This comment has been minimized.

Copy link

@j1nx j1nx commented Nov 7, 2019

Laat me weten als en waarmee je hulp kunt gebruiken.

(Let me know if and with which you can use some help.)

This was referenced Nov 13, 2019
@forslund

This comment has been minimized.

Copy link
Member

@forslund forslund commented Dec 7, 2019

With #2385 merged could you update the issue with specific parts that needs further work?

@j1nx

This comment has been minimized.

Copy link

@j1nx j1nx commented Dec 8, 2019

With the following section in mycroft.conf

{
  "max_allowed_core_version": 19.8,
  "tts":{"google":{"lang": "nl"}},
  "stt":{"module":"google", "google":{"lang": "nl"}},
  "lang":"nl-nl"
}

I can ask for the weather in Dutch and get a response back in Dutch. Don't know which other skills have already been translated, but I would consider; "Addition of rudimentary Dutch support" as done and this can be closed.

Now it is just a matter of translating skills and other sections....

@mikewoudenberg

This comment has been minimized.

Copy link
Contributor Author

@mikewoudenberg mikewoudenberg commented Dec 8, 2019

Yup, with my PR merged and #2411 merged it is working quite nicely right now thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.