Removing default skill pip dependencies #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatchison
force-pushed
the
remove-default-skills-deps
branch
from
d138847
to
4d22356
Compare
MatthewScholefield
approved these changes
Nov 3, 2017
|
I've tested it as well and seems to work just fine. Since @MatthewScholefield has approved it I'll go ahead and merge this |
penrods
pushed a commit
that referenced
this pull request
Nov 9, 2017
A recent PR (#1192) eliminated the requirements that only applied to default skills, not to the core itself. However this caused problems for skills that were previously installed and had their PIP requirements satisfied by the packages that came along with the mycroft-core Debian package previously. As a hackinfix, we now re-run PIP on each skill during the MSM update, but to limit the performance impact this only happens once per session. We shouldn't to removing packages again in the future, so this should be a one-time act that gets removed from MSM in the future (like at 18.02).
penrods
added
the
CLA: Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I have removed what I believe to be the all the pip dependencies for the default skills