Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration system corrections #1196

Merged
merged 3 commits into from Nov 7, 2017

Conversation

forslund
Copy link
Collaborator

@forslund forslund commented Nov 2, 2017

==== Tech Notes ====
inflection was not imported in configuration, no critical errors seem to be caused but may potentially block remote configuration updates.

====  Tech Notes ====
inflection was not imported in configuration
@forslund forslund added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Nov 2, 2017
====  Tech Notes ====
Before the refactoring of the configuration system the
ConfigurationManager allowed loading config files directly from strings.
This commit restores that functionality
@forslund forslund changed the title Add missing inflection import Configuration system corrections Nov 7, 2017
Copy link
Contributor

@LearnedVector LearnedVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearnedVector LearnedVector merged commit 864128c into MycroftAI:dev Nov 7, 2017
@forslund forslund deleted the bugfix/missing-config-import branch July 11, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants