Add optional skill announcement message #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Skill can now implement the get_intro_message() method, which can return a string to be spoken the very first time a skill is run. This is intended to be an announcement, such as further steps necessary to setup the skill. Also stopped generation of the Error message when the expected StopIteration occurs on a intent failure. This confused new developers and poluted the logs. Finally, corrected some documentation typos.
penrods
added
the
CLA: Yes
|
Hello @penrods! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. Comment last updated on November 09, 2017 at 12:44 Hours UTC |
|
Looks good, I've got an idea but I'll submit that as a separate PR. Merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A Skill can now implement the get_intro_message() method, which can return a
string to be spoken the very first time a skill is run. This is intended to
be an announcement, such as further steps necessary to setup the skill.
Also stopped generation of the Error message when the expected StopIteration
occurs on a intent failure. This confused new developers and poluted the logs.
Finally, corrected some documentation typos.