Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove offensive spaces #1216

Merged
merged 3 commits into from Nov 9, 2017
Merged

Remove offensive spaces #1216

merged 3 commits into from Nov 9, 2017

Conversation

penrods
Copy link
Contributor

@penrods penrods commented Nov 9, 2017

Bash likes "rc=$?", not "rc = $?"

Remove offensive spaces
09b76a7 
Bash likes "rc=$?", not "rc = $?"
@penrods penrods added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Nov 9, 2017
penrods added 2 commits November 9, 2017 15:48
Remove usage of bash subshell in MSM
252f731 
Remove usage of bash subshell in MSM for invocation of the
mycroft.message.send module.  The virtualenv wouldn't be created in that
subshell, breaking Github-style installs of Mycroft.
Remove one more subshell
04aa0cc
aatchison
aatchison approved these changes Nov 9, 2017
View changes
Copy link
Contributor

@aatchison aatchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aatchison aatchison merged commit a4db13a into dev Nov 9, 2017
@aatchison aatchison deleted the feature/msm-no-spaces branch November 9, 2017 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatchison aatchison

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@penrods @aatchison