Add mycroft.awoken message when listener is awoken #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
CLA: Yes
forslund
force-pushed
the
feature/wake-up-message
branch
from
88fe311
to
eb40d31
Compare
forslund
changed the title
penrods
reviewed
Dec 6, 2017
mycroft/client/speech/listener.py
Outdated
| @@ -114,7 +114,7 @@ def wake_up(self, audio): | |||
| if self.wakeup_recognizer.found_wake_word(audio.frame_data): | |||
| SessionManager.touch() | |||
| self.state.sleeping = False | |||
| self.__speak(mycroft.dialog.get("i am awake", self.stt.lang)) | |||
| self.emitter.emit('mycroft.awoken') | |||
There was a problem hiding this comment.
Within the listener bus, use "recognizer_loop:awoken"
penrods
reviewed
Dec 6, 2017
mycroft/client/speech/main.py
Outdated
| @@ -135,6 +141,7 @@ def main(): | |||
| loop.on('recognizer_loop:utterance', handle_utterance) | |||
| loop.on('speak', handle_speak) | |||
| loop.on('recognizer_loop:record_begin', handle_record_begin) | |||
| loop.on('mycroft.awoken', handle_awoken) | |||
There was a problem hiding this comment.
Switch to: "recognizer_loop:awoken"
Instead of speaking directly from the listener send a message that the naptime_skill can use to trigger speech and/or other indications that the listener is awake
forslund
force-pushed
the
feature/wake-up-message
branch
from
eb40d31
to
04b8e0e
Compare
|
PR updated according to comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Instead of speaking directly from the listener send a message that the
naptime_skill can use to trigger speech and/or other indications that
the listener is now awake.