Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues-1982 - Add IAM authentication for Watson TTS #1983

Merged
merged 2 commits into from Feb 27, 2019
Merged

Issues-1982 - Add IAM authentication for Watson TTS #1983

merged 2 commits into from Feb 27, 2019

Conversation

LuisReinoso
Copy link
Contributor

Description

Add compatibility for Watson Text To Speech: IAM authentication #1982

How to test

  • You might need a IBM Cloud Account
  • Create a Watson Text To Speech Instance
  • Copy your apikey to mycroft.conf
  "tts": {
    "module": "watson",
    "watson": {
       "voice":"es-LA_SofiaVoice",       
       "apikey": "sdsakdljasklkasnxslahdjasnd55s6dsakdsakjdhas"
     }
  }

Contributor license agreement signed?

CLA [X] (Whether you have signed a CLA - Contributor Licensing Agreement

@pep8speaks
Copy link

pep8speaks commented Feb 9, 2019

Hello @LuisReinoso! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 27, 2019 at 09:41 Hours UTC

@forslund
Copy link
Collaborator

Hi @LuisReinoso looks like a good update will try it out in the coming days. Let me know if you have any issues with the CLA process.

@forslund forslund added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Feb 11, 2019
@LuisReinoso
Copy link
Contributor Author

LuisReinoso commented Feb 14, 2019

Hi @forslund I didn't have problems with CLA.

@forslund forslund added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Feb 27, 2019
@forslund
Copy link
Collaborator

Hi, your CLA has arrived and the code looks good. I've verified that the old user/pass system still works but for some reason my new apikey based instance doesn't work yet (not even using curl). Will give it some time to activate.

The code looks good and correct so I'll probably go ahead and merge this for the release if I can't my auth working.

@forslund
Copy link
Collaborator

Managed to get my creds working...and it's working fine now. Merging.

@forslund forslund merged commit 0714127 into MycroftAI:dev Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants