Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore bus on_message #2101

Merged
merged 1 commit into from Apr 17, 2019

Conversation

@JarbasAl
Copy link
Contributor

commented Apr 16, 2019

Description

previously we could react to all messages in the bus

this was removed in #2024 , not sure if by accident

this adds the "message" message back on

How to test

self.bus.on("message", self.handler)

Contributor license agreement signed?

CLA [ yes] (Whether you have signed a CLA - Contributor Licensing Agreement

@forslund

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Thanks! Merging

@forslund forslund merged commit 6715dae into MycroftAI:dev Apr 17, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 50.492%
Details

@JarbasAl JarbasAl deleted the JarbasAl:bug/on_message branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.