Feature/skill gid #2104
Merged
Feature/skill gid #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
CLA: Yes
forslund
force-pushed
the
feature/skill-gid
branch
2 times, most recently
from
77cfaea
to
cd634b9
Compare
forslund
added
Merge after next release
forslund
force-pushed
the
feature/skill-gid
branch
from
aa6dee6
to
09f5c5a
Compare
This also removes the notion of an owner skill and all skills may update settings on the server.
use the userSkill endpoint instead of skill endpoint to always be able to get settings no matter who the owner is.
- restore storing / loading uuid - use uuid to delete before pushing settingsmeta
skillMetadata could be accessed in settings without it when checking if remote update was needed.
forslund
force-pushed
the
feature/skill-gid
branch
from
09f5c5a
to
4518a11
Compare
forslund
force-pushed
the
feature/skill-gid
branch
from
9b5fac4
to
4bd17d5
Compare
forslund
force-pushed
the
feature/skill-gid
branch
from
4bd17d5
to
2208ee1
Compare
The calls are not implemented and functionality will likely change.
Before sending the skills manifest to the backend attach device uuid as needed.
|
flake8 testing of https://github.com/MycroftAI/mycroft-core on Python 3.7.1 $ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics ./mycroft/api/__init__.py:399:64: F821 undefined name 'skill_gid'
LOG.debug("Deleting remote metadata for {}".format(skill_gid))
^
./mycroft/api/__init__.py:403:39: F821 undefined name 'skill_gid'
"/{}".format(skill_gid))
^
2 F821 undefined name 'skill_gid'
2 |
|
Thanks for reporting. I know I fixed that but must have forgotten to commit. That's what I get for not writing a unittest. Will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Replace skillsmeta hash with skill_gid
How to test
Test with Tartarus and make sure it's working nicely and not crashing the server.
Contributor license agreement signed?
CLA [ Yes ]