Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/skill gid #2104

Merged
merged 10 commits into from May 22, 2019

Conversation

@forslund
Copy link
Member

commented Apr 22, 2019

Description

Replace skillsmeta hash with skill_gid

How to test

Test with Tartarus and make sure it's working nicely and not crashing the server.

Contributor license agreement signed?

CLA [ Yes ]

forslund added 7 commits Apr 8, 2019
This also removes the notion of an owner skill and all skills may update settings on the server.
use the userSkill endpoint instead of skill endpoint to always be able
to get settings no matter who the owner is.
- restore storing / loading uuid
- use uuid to delete before pushing settingsmeta
skillMetadata could be accessed in settings without it when checking if remote update was needed.
@forslund forslund force-pushed the feature/skill-gid branch from 09f5c5a to 4518a11 May 20, 2019
@pep8speaks

This comment has been minimized.

Copy link

commented May 20, 2019

Hello @forslund! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-21 15:48:49 UTC
@forslund forslund force-pushed the feature/skill-gid branch from 9b5fac4 to 4bd17d5 May 20, 2019
@forslund forslund force-pushed the feature/skill-gid branch from 4bd17d5 to 2208ee1 May 21, 2019
forslund added 2 commits May 21, 2019
The calls are not implemented and functionality will likely change.
Before sending the skills manifest to the backend attach device uuid as needed.
@forslund forslund merged commit 1300773 into dev May 22, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 50.461%
Details
@penrods penrods deleted the feature/skill-gid branch May 22, 2019
@cclauss

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

flake8 testing of https://github.com/MycroftAI/mycroft-core on Python 3.7.1

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./mycroft/api/__init__.py:399:64: F821 undefined name 'skill_gid'
            LOG.debug("Deleting remote metadata for {}".format(skill_gid))
                                                               ^
./mycroft/api/__init__.py:403:39: F821 undefined name 'skill_gid'
                         "/{}".format(skill_gid))
                                      ^
2     F821 undefined name 'skill_gid'
2
@forslund

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Thanks for reporting. I know I fixed that but must have forgotten to commit.

That's what I get for not writing a unittest.

Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.