Make is_paired fail early if no uuid in identity #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
davidwagnerkc
approved these changes
Jul 19, 2019
chrisveilleux
requested changes
Jul 22, 2019
Refactors code so no request is sent to backend if the local identity file is empty / has no uuid. Since if this part is missing core already knows that it's not paired correctly.
- Add BackendDown test
forslund
force-pushed
the
feature/is_paired-fail-early
branch
from
e9093db
to
b9fddc7
Compare
chrisveilleux
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Refactors code so no request is sent to backend if the local identity
file is empty / has no uuid. Since if this part is missing core already
knows that it's not paired correctly.
How to test
Check that an unpaired device launches the pairing sequence as intended
Contributor license agreement signed?
CLA [ Yes ]