Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_paired fail early if no uuid in identity #2180

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@forslund
Copy link
Member

commented Jun 30, 2019

Description

Refactors code so no request is sent to backend if the local identity
file is empty / has no uuid. Since if this part is missing core already
knows that it's not paired correctly.

How to test

Check that an unpaired device launches the pairing sequence as intended

Contributor license agreement signed?

CLA [ Yes ]

mycroft/api/__init__.py Show resolved Hide resolved
mycroft/api/__init__.py Outdated Show resolved Hide resolved
mycroft/api/__init__.py Outdated Show resolved Hide resolved
mycroft/api/__init__.py Outdated Show resolved Hide resolved
test/unittests/api/test_api.py Show resolved Hide resolved
forslund added 2 commits Jun 30, 2019
Refactors code so no request is sent to backend if the local identity
file is empty / has no uuid. Since if this part is missing core already
knows that it's not paired correctly.
- Add BackendDown test
@forslund forslund force-pushed the forslund:feature/is_paired-fail-early branch from e9093db to b9fddc7 Jul 23, 2019
@davidwagnerkc davidwagnerkc self-requested a review Jul 29, 2019
@chrisveilleux chrisveilleux merged commit d1915d3 into MycroftAI:dev Jul 29, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 50.173%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.