Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ubuntu & mint (debian like) OS #2209

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@fermulator
Copy link
Contributor

commented Jul 14, 2019

Description

add os_is() and os_is_like() call support for debian-like OSes ; specifically Mint but also ~Ubuntu; (Ubuntu should already be covered via "is like debian" but now we're extra covered)
Also if there is no OS match, we should really prompt the user for what to do.

fixes #2207

How to test

run dev_setup.sh on Linux Mint variant (positive test)
(I'm confident this didn't break debian/ubuntu, but in case we're worried test there too)

I tested the "continue?" clause for no OS match by adding (forging) a return in the os_is() and os_is_like() methods temporarily

Contributor license agreement signed?

  • CLA
add `os_is()` and `os_is_like()` call support for debian-like OSes (specifically Mint, but also cover Ubuntu)
Ubuntu should already be covered via "is like debian" (but now we're extra covered)

Also if there is NO match, we should really prompt the user for what to do.
@devs-mycroft

This comment has been minimized.

Copy link
Collaborator

commented Jul 14, 2019

Hello, @fermulator, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@fermulator

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

Hello, @fermulator, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

(in fact I signed this BEFORE submitting the PR, but maybe there is a delay?)

@forslund

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

I think this looks really good, going to test it during the week and when your CLA signature drops in I'll merge this unless I find something (but it looks nice, simple and good)

@forslund

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

A brief explanation to the CLA delay. There is a bit of manual intervention needed to verify the signature and extract github username. I'm not involved in the process so I can't really speed it up :/

@fermulator

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

(CLA still pending? hmmm)

@forslund

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Hmm, I know the CLA-mail was sent out on Monday morning. I'll poke the person responsible and see if the document has arrived and the list just haven't been updated...

@forslund

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

Apparently your signature did not arrive. You should have a new e-mail with signing instructions in your email now.

@fermulator

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

(clicked through the CLA again)
EDIT: did the final process on Jul22, I did not realize there were steps beyond the "clicking" portion initially ... completed the "hellosign" now

@devs-mycroft devs-mycroft added CLA: Yes and removed CLA: Needed labels Jul 27, 2019
@forslund

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Sorry for the delay, the CLA dropped but I'm on vacation so I'm a bit behind on communication. Merging this now.

Many thanks for the nice and clean contribution!

@forslund forslund merged commit 3a68f75 into MycroftAI:dev Aug 2, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 50.131%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.