New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ubuntu & mint (debian like) OS #2209
support ubuntu & mint (debian like) OS #2209
Conversation
add `os_is()` and `os_is_like()` call support for debian-like OSes (specifically Mint, but also cover Ubuntu) Ubuntu should already be covered via "is like debian" (but now we're extra covered) Also if there is NO match, we should really prompt the user for what to do.
|
Hello, @fermulator, thank you for helping with the Mycroft project! We welcome everyone To protect yourself, the project, and users of Mycroft technologies we require Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank |
(in fact I signed this BEFORE submitting the PR, but maybe there is a delay?) |
|
I think this looks really good, going to test it during the week and when your CLA signature drops in I'll merge this unless I find something (but it looks nice, simple and good) |
|
A brief explanation to the CLA delay. There is a bit of manual intervention needed to verify the signature and extract github username. I'm not involved in the process so I can't really speed it up :/ |
|
(CLA still pending? hmmm) |
|
Hmm, I know the CLA-mail was sent out on Monday morning. I'll poke the person responsible and see if the document has arrived and the list just haven't been updated... |
|
Apparently your signature did not arrive. You should have a new e-mail with signing instructions in your email now. |
|
(clicked through the CLA again) |
|
Sorry for the delay, the CLA dropped but I'm on vacation so I'm a bit behind on communication. Merging this now. Many thanks for the nice and clean contribution! |
Description
add
os_is()andos_is_like()call support for debian-like OSes ; specifically Mint but also ~Ubuntu; (Ubuntu should already be covered via "is like debian" but now we're extra covered)Also if there is no OS match, we should really prompt the user for what to do.
fixes #2207
How to test
run
dev_setup.shon Linux Mint variant (positive test)(I'm confident this didn't break debian/ubuntu, but in case we're worried test there too)
I tested the "continue?" clause for no OS match by adding (forging) a
returnin theos_is()andos_is_like()methods temporarilyContributor license agreement signed?