Split mycroft.skills.core #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
forslund
force-pushed
the
refactor/split-skills-core
branch
2 times, most recently
from
1082081
to
7c1ffe2
Compare
|
I definitely like this reorg! |
chrisveilleux
requested changes
Jul 22, 2019
- MycroftSkill and related core functions to mycroft_skill.py - FallbackSkill to fallback_skill.py - Add important classes decorators and functions to __init__.py - move SkillGUI class to the enclosure along with the other enclosure interfaces core.py retains the same members as previously by means of imports to retain backwards compatibility. When most of the available skills starts using this new structure properly
forslund
force-pushed
the
refactor/split-skills-core
branch
from
7c1ffe2
to
b7b5e9b
Compare
|
My original intent was just to move things around into new locations but I can do some additional refactoring as you've suggested. |
Update docstrings of the files affected by this reoriganization. - PEP 257 - Add missing
chrisveilleux
approved these changes
Jul 22, 2019
forslund
added
Merge after next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
core.py retains the same members as previously by means of imports to
retain backwards compatibility. When most of the available skills starts
using this new structure properly.
This makes some of the code easier to view. the mycroft_skill.py still weighs in at ~1400 LOC and we should work at splitting that out in more logical components. I have a suggestion as WIP using a couple of member classes, but the initial split-up is a good first step.
How to test
Make sure that existing skills load and executes like before.
Contributor license agreement signed?
CLA [ Yes ]