Allow startup if update attempt occurs #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update_attempt will block waiting for the update to complete and the update will shutdown the running skills process if an update is needed.
devs-mycroft
added
the
CLA: Yes
forslund
force-pushed
the
bugfix/system-update
branch
from
a7205d2
to
e9cc683
Compare
|
Ping @davidwagnerkc and @chrisveilleux. Can you check on this, it's sort of a critical issue. I removed the dialog on update attempt I had originally added. Since it'd speak for the Mark-2 which can't do an update yet... |
chrisveilleux
approved these changes
Aug 10, 2019
|
Tested on Mark I. Blocked during update then started up as expected. |
davidwagnerkc
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
This changes the flow to allow proceeding to do proper startup after a system update attempt.
update_attempt will block waiting for the update to complete and if an actual update occurs it (the .deb update script) will shutdown the running skills process if an update is actually performed.
I also added a short voice confirmation that we're checking for updates.
How to test
Check that an unpaired mark-1 starts up ok
Contributor license agreement signed?
CLA [ Yes ]