Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow startup if update attempt occurs #2236

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@forslund
Copy link
Member

commented Jul 26, 2019

Description

This changes the flow to allow proceeding to do proper startup after a system update attempt.

update_attempt will block waiting for the update to complete and if an actual update occurs it (the .deb update script) will shutdown the running skills process if an update is actually performed.

I also added a short voice confirmation that we're checking for updates.

How to test

Check that an unpaired mark-1 starts up ok

Contributor license agreement signed?

CLA [ Yes ]

update_attempt will block waiting for the update to complete and the
update will shutdown the running skills process if an update is needed.
@forslund forslund requested a review from chrisveilleux Jul 26, 2019
@forslund forslund added the type: bug label Jul 26, 2019
@forslund forslund requested a review from davidwagnerkc Aug 2, 2019
@forslund forslund force-pushed the forslund:bugfix/system-update branch from a7205d2 to e9cc683 Aug 10, 2019
@forslund

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

Ping @davidwagnerkc and @chrisveilleux. Can you check on this, it's sort of a critical issue.

I removed the dialog on update attempt I had originally added. Since it'd speak for the Mark-2 which can't do an update yet...

@davidwagnerkc

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Tested on Mark I. Blocked during update then started up as expected.

@davidwagnerkc davidwagnerkc merged commit db2ea07 into MycroftAI:dev Aug 12, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 51.668%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.