Refactor skill manager #2237
Merged
Refactor skill manager #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added some docstrings - put config retrieval in a function - added log messages
- fixed spelling error - renamed variable that shadowed built-in
- reordered imports - refactored docstrings for consistency - renamed camel case variables to use snake case
- renamed the message bus client - abstracted message bus config loading so service and client can use same code.
… it is a backport that inherits from the new MessageBusClient class. Added a deprecation comment as well.
… may cause breakage. added todo to include in next major release.
- broke big functions up into classes/methods - reworked the multiple calls to is_paired() into a single call to minimize API calls and improve performance a bit - added more documentation - added more logging - other miscellaneous cleaning stuff
…into this class... for now.
…to refactor-skill-service
forslund
reviewed
Aug 15, 2019
forslund
reviewed
Aug 19, 2019
|
There are some issues handling reloading of skills along with a couple of issues with the activate/deactivate handlers. I've looked it over and posted a suggestion, see commit list here. If you're okay with the changes just cherry pick those commits to your branch. There is some possibilities of threading issues when calling the activate/deactivate methods but those will basically only hit skill developers so we can postpone that. I've also skipped code style check we can refactor this further at a later date. |
- Separate reload required check from performing reload to make logic easier to follow - Track skills that failed to load to handle infinite loop at first load if skill fails to load - Allow reloading skills that has failed to load
|
@forslund I merged your fixes into this branch. Thanks for putting it through its paces. |
forslund
force-pushed
the
refactor-skill-manager
branch
2 times, most recently
from
57a3956
to
eeabbe5
Compare
- create activate, deactivate and unload methods for skill_loader objects - add sanity checks before activating and deactivating skills - Update activation/deactivation test cases
forslund
force-pushed
the
refactor-skill-manager
branch
from
eeabbe5
to
711cc6c
Compare
- Fix failures introduced when creating unload method on SkillLoader - Fix failing test cases where returnvalue is needed - Fix mock config to allow updates - Fix invalid assert in test_skill_updater.py - Replace assert_called_once with assert_called_once_with to make python 3.5 tests work Fix rest of python 3.5 tests
forslund
force-pushed
the
refactor-skill-manager
branch
from
711cc6c
to
2ae5ef4
Compare
|
Finally figured out why your test cases were failing on Python 3.5. Merging this now. |
|
The commit history here is so messed up I'll do a squash to make a sane commit :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Refactoring of the mycroft.skill.skill_manager.py module.
How to test
This is a refactor so all functionality should work as it did before these changes.
Contributor license agreement signed?
CLA [yes]