Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined name: Except --> Exception #2241

Merged
merged 1 commit into from Aug 7, 2019
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 30, 2019

Except is an undefined name in this context with the potential to raise NameError at runtime instead of the desired Exception and message.

Description

(Description of what the PR does, such as fixes # {issue number})

Use a defined term instead of an undefined term.

How to test

(Description of how to validate or test this PR)

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

__Except__ is an undefined name in this context with the potential to raise __NameError__ at runtime instead of the desired Exception and message.
@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Jul 30, 2019
@devs-mycroft
Copy link
Collaborator

Hello, @cclauss, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@cclauss cclauss changed the title Undeefined name: Except --> Exception Undefined name: Except --> Exception Jul 30, 2019
@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Aug 7, 2019
@krisgesling
Copy link
Contributor

Hi Christian, nice spotting!

We received the signed CLA, thanks for contributing to open source 😄

@krisgesling krisgesling merged commit 75c9add into MycroftAI:dev Aug 7, 2019
@cclauss cclauss deleted the patch-1 branch August 8, 2019 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants