Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/download precise #2245

Merged
merged 3 commits into from Aug 20, 2019

Conversation

@forslund
Copy link
Member

commented Aug 2, 2019

Description

Was meaning to send this up last weekend but seem to have not gotten around to it.

  • Fixes an issue when the mic returns None
  • Retries download if petactl errors (connection error or dns lookup errors for example)

petactl needs to be investigated more, sometimes a broken download doesn't seem to be

How to test

I guess trying it out is the best way.

Contributor license agreement signed?

CLA [ Yes ]

forslund added 3 commits Jul 26, 2019
Mic may return None when aborted due to a reload of wake-word engine
- Reorder includes
- Add basic docstrings for the available engines
- simplify super()
- remove unneccessary "/" chars
Will retry the download of precise once per minute
@forslund forslund requested a review from davidwagnerkc Aug 2, 2019
@davidwagnerkc

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Number of things in this one I like. I'll test it out today.

@forslund

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Copy link
Contributor

left a comment

Works as expected!

@davidwagnerkc davidwagnerkc merged commit e5f71cf into MycroftAI:dev Aug 20, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 51.66%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.