Bugfix/download precise #2245
Merged
Bugfix/download precise #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic may return None when aborted due to a reload of wake-word engine
- Reorder includes - Add basic docstrings for the available engines - simplify super() - remove unneccessary "/" chars
Will retry the download of precise once per minute
devs-mycroft
added
the
CLA: Yes
|
Number of things in this one I like. I'll test it out today. |
|
Feel free to push any number of fixes / updates you see necessary to
embetter this.
Den fre 2 aug. 2019 kl 13:42 skrev David Wagner <notifications@github.com>:
… Number of things in this one I like. I'll test it out today.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2245?email_source=notifications&email_token=AAGENP3WXRPDMADHWPKBZV3QCQMT3A5CNFSM4II2WZD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NQI3Q#issuecomment-517669998>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGENP4UR5UPQFRUGAI7ABLQCQMT3ANCNFSM4II2WZDQ>
.
--
Smoke me a kipper, I'll be back for breakfast
Åke Forslund
Mycroft.AI <https://mycroft.ai/> | Software Developer | 816.674.6583
<816-674-6583>
300 E. 39th Street,
<https://maps.google.com/?q=300+E.+39th+Street,%C2%A0Kansas+City,+MO+64111&entry=gmail&source=g>Kansas
City, MO 64111
<https://maps.google.com/?q=300+E.+39th+Street,%C2%A0Kansas+City,+MO+64111&entry=gmail&source=g>
|
davidwagnerkc
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Was meaning to send this up last weekend but seem to have not gotten around to it.
Nonepetactl needs to be investigated more, sometimes a broken download doesn't seem to be
How to test
I guess trying it out is the best way.
Contributor license agreement signed?
CLA [ Yes ]