Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pairing check to the relevant stt backends #2248

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@forslund
Copy link
Member

commented Aug 3, 2019

Description

The pairing trigger should only be triggered by the 401 status for the
Mycroft hosted STT backends. Doing it for other STT's is only confusing.

This creates the decorator 'requires_pairing' that can be applied to the STT modules where it's relevant.

This adds the decorator to the MycroftSTT and the MycroftDeepSpeechSTT

How to test

  • Assert that voice input is working
  • shutdown mycroft
  • remove/rename identity2.json
  • ./start-mycroft.sh bus
  • python mycroft.client.speech

Check that any input comes back as "pair my device"

Contributor license agreement signed?

CLA [ Yes ]

The pairing trigger should only be triggered by the 401 status for the
Mycroft hosted STT backends. Doing it for other STT's is only confusing.

This creates the decorator 'requires_pairing' that can be applied to the STT modules where it's relevant.

This adds the decorator to the MycroftSTT and the MycroftDeepSpeechSTT
@forslund forslund requested a review from davidwagnerkc Aug 3, 2019
Copy link
Contributor

left a comment

Working as expected. 👍

@davidwagnerkc davidwagnerkc merged commit 5f6db09 into MycroftAI:dev Aug 13, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 51.711%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.