Bugfix/delete settings meta #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change from the old uuid to the newer skill_gid fixing the invalid reference to skill_gid.
devs-mycroft
added
the
CLA: Yes
chrisveilleux
approved these changes
Aug 10, 2019
cclauss
approved these changes
Aug 11, 2019
test/unittests/api/test_api.py
Outdated
| mock_identity = mock.MagicMock() | ||
| mock_identity.is_expired.return_value = False | ||
| mock_identity.uuid = '1234' | ||
| mock_identity_get.return_value = mock_identity |
There was a problem hiding this comment.
4 lines —> 1 line: mock_identity_get.return_value = create_identity('1234')
test/unittests/api/test_api.py
Outdated
| mock_identity = mock.MagicMock() | ||
| mock_identity.is_expired.return_value = False | ||
| mock_identity.uuid = '1234' | ||
| mock_identity_get.return_value = mock_identity |
There was a problem hiding this comment.
4 lines —> 1 line: mock_identity_get.return_value = create_identity('1234')
test/unittests/api/test_api.py
Outdated
| mock_identity = mock.MagicMock() | ||
| mock_identity.is_expired.return_value = False | ||
| mock_identity.uuid = '1234' | ||
| mock_identity_get.return_value = mock_identity |
There was a problem hiding this comment.
4 lines —> 1 line: mock_identity_get.return_value = create_identity('1234')
There was a problem hiding this comment.
Good catch, totally missed replacing in the new tests.
- remove duplicated code for creating identity mock - separate the Api class tests from the rest of the tests
forslund
force-pushed
the
bugfix/delete-settings-meta
branch
from
c920d6a
to
b68fff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Fixes the incorrect variable name reported by @cclauss
This PR also adds a couple of simple unittests for these methods and does a bit of simplification of the api tests.
How to test
Check that the unittests passes.
Contributor license agreement signed?
CLA [ Yes ]