Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dnf to be used as pkg manager for Fedora #2255 #2257

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@vegerot
Copy link
Contributor

commented Aug 14, 2019

Description

(Description of what the PR does, such as fixes # {issue number})
@guystreeter pointed out he had issues using dev_setup.sh on Fedora (#2255 )
He mentioned that replacing os_is fedora for os_is_like fedora resolved his issue. So I substituted the statement elif os_is_like fedora for elif os_is_like fedora || os_is fedora. Which should fix the issue

How to test

Run ./dev_setup.sh on systems similar to:

$ cat /etc/os-release 
NAME=Fedora
VERSION="30 (Workstation Edition)"
ID=fedora
VERSION_ID=30
VERSION_CODENAME=""
PLATFORM_ID="platform:f30"
PRETTY_NAME="Fedora 30 (Workstation Edition)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:30"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f30/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=30
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=30
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

Contributor license agreement signed?

CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement
(I filled out the form there, and am awaiting the response email 馃摟)
edit: all signed now!

@devs-mycroft

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

Hello, @vegerot, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@forslund

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Thanks @vegerot looks good. Will merge this as soon as the CLA has landed.

@forslund

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Hi again @vegerot did you get a CLA mail or has it stalled someplace along the way? Let us know if wew need to look at anything.

@vegerot

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@forslund I am not sure what the issue is. I got the email last week and thought I filled it all out. Please let me know how best to proceed.

image

image

@forslund

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

I will poke around here and see if the hello-sign thing has been missed on our end. Thanks for letting us know.

@vegerot

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

No problem. Hopefully everything checks out and can get merged soon

@forslund forslund added CLA: Yes and removed CLA: Needed labels Aug 22, 2019
@forslund

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

I've gotten confirmation that your CLA has been received but you haven't been entered into the official list of signers yet.

I'm updating status manually for now.

@forslund

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Many thanks for this contribution, it looks good all over. Sorry for the delay with the administration.

Merging!

@forslund forslund merged commit d68c69f into MycroftAI:dev Aug 22, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on bugfix/fedora at 51.723%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.