Fix TypeError for number values in settings #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some instances, the backend returns number setting values as an integer rather than a string. This has been seen in the wild but has been difficult to replicate. The circumstances under which it happens are still unclear. I was able to semi-consistently have a number returned as int from the [Severe Weather Skill](https://github.com/domcross/severe-weather-information-skill) when editing an unrelated setting. To test, remove the 3 character country code (`[A-Z]{3} - `) from the service options of this skill . This seems to be the quickest fix for it, but worth investigating further from the backend.
devs-mycroft
added
the
CLA: Yes
|
@chrisveilleux - just FYI - I ran into the same TypeError reported by malevolent in the chat today |
chrisveilleux
approved these changes
Aug 16, 2019
Yeah, I am of the opinion that the logic in core needs to be changed. I am working on a change right now that plays more nicely with the backend. This will do as a temp fix until I can get my new thing working. |
|
@chrisveilleux Just remember that the backend needs to be backwards compatible and should send these numbers as strings so older versions of core will still work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In some instances, the backend returns number setting values as an integer rather than a string.
This seems to be the quickest fix for it, but worth investigating further from the backend.
How to test
This has been seen in the wild but has been difficult to replicate. The circumstances under which it happens are still unclear. I was able to semi-consistently have a number returned as int from the Severe Weather Skill when editing an unrelated setting. To test, remove the 3 character country code (
[A-Z]{3} -) from the service options of this skill .Contributor license agreement signed?