Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where skills fail during initialize() #2260

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@forslund
Copy link
Member

commented Aug 20, 2019

Description

An exception in skill's initialize method would be reraised and cause
the main loading routine to halt. This does not reraise the exception,
instead the instance reference is removed.

How to test

Assert that a skill with an error in the initialize method still allows other skills to be reloaded.

Contributor license agreement signed?

CLA [ Yes ]

@forslund forslund requested review from chrisveilleux and davidwagnerkc Aug 20, 2019
@forslund forslund force-pushed the forslund:bugfix/initialize-failure branch 2 times, most recently from c0e5226 to 46f52c7 Aug 20, 2019
An exception in skill's initialize method would be reraised and cause
the main loading routine to halt. This does not reraise the exception,
instead the instance reference is removed.
@forslund forslund force-pushed the forslund:bugfix/initialize-failure branch from 46f52c7 to bd0456f Aug 21, 2019
@forslund forslund merged commit 4a9c2a4 into MycroftAI:dev Aug 21, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 53.004%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.