Fix issue where skills fail during initialize() #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
forslund
force-pushed
the
bugfix/initialize-failure
branch
2 times, most recently
from
c0e5226
to
46f52c7
Compare
chrisveilleux
approved these changes
Aug 20, 2019
An exception in skill's initialize method would be reraised and cause the main loading routine to halt. This does not reraise the exception, instead the instance reference is removed.
forslund
force-pushed
the
bugfix/initialize-failure
branch
from
46f52c7
to
bd0456f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
An exception in skill's initialize method would be reraised and cause
the main loading routine to halt. This does not reraise the exception,
instead the instance reference is removed.
How to test
Assert that a skill with an error in the initialize method still allows other skills to be reloaded.
Contributor license agreement signed?
CLA [ Yes ]