Bugfix/ prevent uninstall of WINE and other programs #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgesling
added
Type: Bug - complex
Status: Work in progress
forslund
reviewed
Aug 22, 2019
|
This seems good. Is there any more changes you're planning to do or should I go ahead and merge it? |
|
I just haven't been able to boot into Mint to test it out, GNOME Boxes doesn't seem to like their ISO's |
Checks for the existence of libjack-jackd2-0 on debian systems and suggests the user cancel the installation if found. Resolves issue MycroftAI#2238
krisgesling
force-pushed
the
bugfix/wine-uninstall
branch
from
a85d9a6
to
a64ca51
Compare
|
+1 for real world testing, turns out I had the package name wrong Have squashed the commits for the sake of mycroft-core's history This should be good to go! |
krisgesling
removed
the
Status: Work in progress
|
Excellent. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Checks for the existence of
lib-jack-2-0on debian systems and if found provides option to abort the install. Resolves #2238How to test
Install WINE then attempt to install Mycroft
Contributor license agreement signed?