Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ prevent uninstall of WINE and other programs #2266

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@krisgesling
Copy link
Contributor

commented Aug 22, 2019

Description

Checks for the existence of lib-jack-2-0 on debian systems and if found provides option to abort the install. Resolves #2238

How to test

Install WINE then attempt to install Mycroft

Contributor license agreement signed?

dev_setup.sh Outdated Show resolved Hide resolved
@forslund

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

This seems good. Is there any more changes you're planning to do or should I go ahead and merge it?

@krisgesling

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

I just haven't been able to boot into Mint to test it out, GNOME Boxes doesn't seem to like their ISO's

Checks for the existence of libjack-jackd2-0 on debian systems
and suggests the user cancel the installation if found.

Resolves issue #2238
@krisgesling krisgesling force-pushed the krisgesling:bugfix/wine-uninstall branch from a85d9a6 to a64ca51 Aug 22, 2019
@krisgesling

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

+1 for real world testing, turns out I had the package name wrong

Have squashed the commits for the sake of mycroft-core's history

This should be good to go!

@forslund

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Excellent. Merging

@forslund forslund merged commit 0eb0a59 into MycroftAI:dev Aug 22, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 53.004%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.