Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send recording message after playing recording sound #2273

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@forslund
Copy link
Member

commented Aug 26, 2019

Description

This allows the start recording sound to play before any ducking starts.

How to test

Check that the recognizer_loop:record_begin is still sent. The branch feature/listen-ducking of the volume skill can be used.

Contributor license agreement signed?

CLA [ Yes ]

This allows the sound to play before any ducking starts
@forslund forslund requested a review from davidwagnerkc Aug 26, 2019
@forslund forslund merged commit 2684bee into MycroftAI:dev Aug 26, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 52.986%
Details
@forslund forslund deleted the forslund:feature/move-listening-message branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.