Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/log merger #2277

Merged
merged 6 commits into from Aug 30, 2019
Merged

Feature/log merger #2277

merged 6 commits into from Aug 30, 2019

Conversation

chrisveilleux
Copy link
Member

Description

Add a new script to merge Mycroft process log files into a single file for debugging purposes. Also reformats the log output.

How to test

Start Mycroft processes and see that date and other new formatting is present in log files. Run the script against log files on a device to see the merged output.

Contributor license agreement signed?

CLA [yes]

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Aug 29, 2019
@forslund
Copy link
Collaborator

When testing this previously I ran into a locale issue, specifically differences in the decimal point character (',' over here compared to '.' over there)

I made these changes to make it (hopefully) decimal point agnostic

@chrisveilleux
Copy link
Member Author

chrisveilleux commented Aug 30, 2019 via email

@forslund
Copy link
Collaborator

Works! Merging!

@forslund forslund merged commit c455ea7 into dev Aug 30, 2019
@chrisveilleux chrisveilleux deleted the feature/log-merger branch August 30, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants