Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/log merger #2277

Merged
merged 6 commits into from Aug 30, 2019

Conversation

@chrisveilleux
Copy link
Member

commented Aug 29, 2019

Description

Add a new script to merge Mycroft process log files into a single file for debugging purposes. Also reformats the log output.

How to test

Start Mycroft processes and see that date and other new formatting is present in log files. Run the script against log files on a device to see the merged output.

Contributor license agreement signed?

CLA [yes]

…or historical log viewing. this script is good for viewing merged process logs at boot time or at a point in the past.
@chrisveilleux chrisveilleux requested a review from forslund Aug 29, 2019
@forslund

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

When testing this previously I ran into a locale issue, specifically differences in the decimal point character (',' over here compared to '.' over there)

I made these changes to make it (hopefully) decimal point agnostic

@chrisveilleux

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

…he output file to suite different locales
@forslund

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

Works! Merging!

@forslund forslund merged commit c455ea7 into dev Aug 30, 2019
3 of 4 checks passed
3 of 4 checks passed
License Compliance 10 issues found
Details
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 52.989%
Details
@chrisveilleux chrisveilleux deleted the feature/log-merger branch Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.