Enable support for pulseaudio ducking #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulseaudio allows corking / ducking for streams with prioritized roles This sets the role for the mycroft speech to "phone" and all other to "music" if the config tts->pulse_duck is set to true.
- Remove unused imports - Correct docstrings
devs-mycroft
added
the
CLA: Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
This utilizes the pulseaudio ducking feature by assigning the audio streams "roles"
To enable this set the config
tts->pulse_ducktotrue.The value is default to false since there are a couple of pulseaudio configs that are needed to make this work smoothly:
This PR also removes the old manual pulse audio ducking code.
How to test
Check that the feature can be turned on by using the config key.
Contributor license agreement signed?
CLA [ Yes ]