Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for pulseaudio ducking #2282

Merged
merged 3 commits into from Sep 2, 2019

Conversation

@forslund
Copy link
Member

commented Aug 31, 2019

Description

This utilizes the pulseaudio ducking feature by assigning the audio streams "roles"

To enable this set the config tts->pulse_duck to true.

The value is default to false since there are a couple of pulseaudio configs that are needed to make this work smoothly:

pactl unload-module module-role-cork
load-module module-role-ducking
unload-module module-stream-restore

This PR also removes the old manual pulse audio ducking code.

How to test

Check that the feature can be turned on by using the config key.

Contributor license agreement signed?

CLA [ Yes ]

forslund added 3 commits Aug 27, 2019
Pulseaudio allows corking / ducking for streams with prioritized roles
This sets the role for the mycroft speech to "phone" and all other to
"music" if the config tts->pulse_duck is set to true.
- Remove unused imports
- Correct docstrings
@forslund forslund requested a review from davidwagnerkc Aug 31, 2019
Copy link
Contributor

left a comment

🦆

@forslund forslund merged commit a1656de into MycroftAI:dev Sep 2, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 53.22%
Details
@forslund forslund deleted the forslund:feature/pulse_role branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.