Update skill-tester for 19.08 and add basic support for wait_for_response #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
forslund
force-pushed
the
test/wait_for_response
branch
from
cece5d3
to
3922f9a
Compare
krisgesling
reviewed
Sep 2, 2019
Split the long function into several smaller ones just retaining the main logic.
Creates rules.py containing logic for the small rule snippets for each entry in the json
forslund
force-pushed
the
test/wait_for_response
branch
from
3922f9a
to
edc6192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
wait_for_responsein the most basic wayHow to test
Check that current skill tester works:
https://jenkins.mycroft.team/job/19.08-skill-tester/8/console
(failure here is valid due to current state of the weather skill)
Contributor license agreement signed?
CLA [ Yes ]