Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skill-tester for 19.08 and add basic support for wait_for_response #2284

Merged
merged 4 commits into from Sep 2, 2019

Conversation

@forslund
Copy link
Member

commented Sep 1, 2019

Description

  • Allow skill tester to handle wait_for_response in the most basic way
  • Fix moved references (LOG)
  • Basic refactoring making some of the bigger methods less complex.

How to test

Check that current skill tester works:
https://jenkins.mycroft.team/job/19.08-skill-tester/8/console
(failure here is valid due to current state of the weather skill)

Contributor license agreement signed?

CLA [ Yes ]

@forslund forslund requested a review from krisgesling Sep 1, 2019
@forslund forslund force-pushed the test/wait_for_response branch from cece5d3 to 3922f9a Sep 1, 2019
Copy link
Contributor

left a comment

Nice refactoring, I personally find it much easier to read

test/integrationtests/skills/skill_tester.py Outdated Show resolved Hide resolved
forslund added 4 commits Aug 30, 2019
Split the long function into several smaller ones just retaining the
main logic.
Creates rules.py containing logic for the small rule snippets for each
entry in the json
@forslund forslund force-pushed the test/wait_for_response branch from 3922f9a to edc6192 Sep 2, 2019
@krisgesling krisgesling merged commit 4385406 into dev Sep 2, 2019
3 of 4 checks passed
3 of 4 checks passed
License Compliance FOSSA is analyzing this commit
Details
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 53.22%
Details
@forslund forslund deleted the test/wait_for_response branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.