Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove deprecated 19.08 #2285

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@forslund
Copy link
Member

commented Sep 2, 2019

Description

Remove deprecated things.

How to test

Make sure core still runs.

Contributor license agreement signed?

CLA [ Yes ]

@forslund forslund force-pushed the forslund:feature/remove-deprecated-19.08 branch from 3a54730 to aff778d Sep 2, 2019
Name change to remove collision with the builin type.
@forslund forslund force-pushed the forslund:feature/remove-deprecated-19.08 branch from aff778d to 3b2c726 Sep 2, 2019
@forslund forslund requested review from chrisveilleux and davidwagnerkc Sep 2, 2019
Copy link
Contributor

left a comment

Tested with 19.08 skills and there were no explosions 👍

@forslund forslund merged commit 5477bfe into MycroftAI:dev Sep 2, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 53.243%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.