Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove deprecated 19.08 #2285

Merged
merged 2 commits into from Sep 2, 2019

Conversation

forslund
Copy link
Collaborator

@forslund forslund commented Sep 2, 2019

Description

Remove deprecated things.

How to test

Make sure core still runs.

Contributor license agreement signed?

CLA [ Yes ]

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Sep 2, 2019
@forslund forslund force-pushed the feature/remove-deprecated-19.08 branch from 3a54730 to aff778d Compare September 2, 2019 10:45
Name change to remove collision with the builin type.
Copy link
Contributor

@davidwagnerkc davidwagnerkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with 19.08 skills and there were no explosions 👍

@forslund forslund merged commit 5477bfe into MycroftAI:dev Sep 2, 2019
@forslund forslund deleted the feature/remove-deprecated-19.08 branch November 28, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants