Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/mycroft skill #2286

Merged
merged 2 commits into from Sep 2, 2019
Merged

Bugfix/mycroft skill #2286

merged 2 commits into from Sep 2, 2019

Conversation

forslund
Copy link
Collaborator

@forslund forslund commented Sep 2, 2019

Description

Fix a couple of regressions

  • scheduled event handlers without "message" parameter would never run.
  • Padatious intents wouldn't be enabled / disabled correctly.

Contributor license agreement signed?

CLA [ Yes ]

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Sep 2, 2019
Fix issue when the handler is specified without an argument parameter.
Padatious is still not the greatest at enabling / disabling intents but
it's slightly better.
@forslund
Copy link
Collaborator Author

forslund commented Sep 2, 2019

Branch rebased and should now look sane.

Copy link
Contributor

@davidwagnerkc davidwagnerkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the Spotify stop issues 👍

@forslund
Copy link
Collaborator Author

forslund commented Sep 2, 2019

Thanks for testing!

@forslund forslund merged commit a027e0d into MycroftAI:dev Sep 2, 2019
@forslund forslund deleted the bugfix/mycroft-skill branch November 28, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants