Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/mycroft skill #2286

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@forslund
Copy link
Member

commented Sep 2, 2019

Description

Fix a couple of regressions

  • scheduled event handlers without "message" parameter would never run.
  • Padatious intents wouldn't be enabled / disabled correctly.

Contributor license agreement signed?

CLA [ Yes ]

@forslund forslund requested a review from davidwagnerkc Sep 2, 2019
forslund added 2 commits Sep 2, 2019
Fix issue when the handler is specified without an argument parameter.
Padatious is still not the greatest at enabling / disabling intents but
it's slightly better.
@forslund forslund force-pushed the forslund:bugfix/mycroft-skill branch from bedb131 to 32cfe0d Sep 2, 2019
@forslund

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

Branch rebased and should now look sane.

@forslund forslund requested a review from chrisveilleux Sep 2, 2019
Copy link
Contributor

left a comment

Fixes the Spotify stop issues 👍

@forslund

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

Thanks for testing!

@forslund forslund merged commit a027e0d into MycroftAI:dev Sep 2, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 53.299%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.