Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor/skill settings split #2287
Complete rethink of how we deal with settings and settingsmeta in core
How to test
Make changes to settingsmeta.json for a skill. Confirm that the changes are accurately reflected on the backend. Make changes to skill settings at account.mycroft.ai. Confirm that changes are accurately reflected in settings.json
Contributor license agreement signed?
What's breaking here, The callback registration and the .store() methods? Is there a way of preserving these so we don't break the API without depreciation warning?
The save_settings should only occur if the settings were changed.
Let's move as much of the logic for this outside of the mycroft_skill.
Also let's drop the refactoring commits so it's easier to review.
Implemented the change you suggested to make the skill API right again.
I don't think I can move any more of the logic outside of MycroftSkill. The only thing I really added was a way to deal with settings changes when they occur.
Added logic to only call save_settings if settings change
- Correct settingsmeta upload endpoint - Remove test for delete settingsmeta endpoint - Fix usage of Pathlib for python 3.4 and 3.5