Refactor/skill settings split #2287
Conversation
devs-mycroft
added
the
CLA: Yes
forslund
added
the
Status: Work in progress
|
What's breaking here, The callback registration and the .store() methods? Is there a way of preserving these so we don't break the API without depreciation warning? The save_settings should only occur if the settings were changed. Let's move as much of the logic for this outside of the mycroft_skill. Also let's drop the refactoring commits so it's easier to review. |
|
Implemented the change you suggested to make the skill API right again. I don't think I can move any more of the logic outside of MycroftSkill. The only thing I really added was a way to deal with settings changes when they occur. Added logic to only call save_settings if settings change |
forslund
force-pushed
the
refactor/skill-settings-split
branch
from
1956de2
to
84e4fea
Compare
There was a problem hiding this comment.
Some things I've noted when running the branch prematurely. You're probably aware of them but in case you weren't I'll flag them to save some time.
Also setting the line skill_loader.py L224 should be removed. I think we'll just drop this "feature".
forslund
force-pushed
the
refactor/skill-settings-split
branch
6 times, most recently
from
81a5cac
to
cfb9594
Compare
forslund
removed
the
Status: Work in progress
forslund
force-pushed
the
refactor/skill-settings-split
branch
from
cfb9594
to
40710de
Compare
- Correct settingsmeta upload endpoint - Remove test for delete settingsmeta endpoint - Fix usage of Pathlib for python 3.4 and 3.5
… properly initialized. added some logging
…d to the function are a instance of the Settings class.
forslund
force-pushed
the
refactor/skill-settings-split
branch
from
40710de
to
f7c4700
Compare
|
Backend has been updated. Merging this now. |
Description
Complete rethink of how we deal with settings and settingsmeta in core
How to test
Make changes to settingsmeta.json for a skill. Confirm that the changes are accurately reflected on the backend. Make changes to skill settings at account.mycroft.ai. Confirm that changes are accurately reflected in settings.json
Contributor license agreement signed?
CLA [yes]