Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make messagebus service respect loglevel #2291

Merged

Conversation

@forslund
Copy link
Member

commented Sep 6, 2019

Description

Sends the --logging=None parameter to tornado to ensure that the mycroft log level is respected.

How to test

Check that if log level is set to DEBUG in the config file bus messages are logged.

Contributor license agreement signed?

CLA [ Yes ]

@forslund forslund requested a review from davidwagnerkc Sep 6, 2019
Copy link
Contributor

left a comment

Mystery solved 🎉 Good work!

@davidwagnerkc davidwagnerkc merged commit d5ec11d into MycroftAI:dev Sep 6, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 53.292%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.