Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions when reloading skills #2299

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@forslund
Copy link
Member

commented Sep 11, 2019

Description

I've experienced a couple of halts of the skill manager due to FileNotFoundErrors when reloading skills.

This will explicitly

  • Explicitly catch FileNotFoundError
  • Do a general catch and log for other exceptions

How to test

Make sure skill service is still loading and reloading as expected

Contributor license agreement signed?

CLA [ Yes ]

- Explicitly catch FileNotFoundError
- Do a general catch and log for other exceptions
@forslund forslund requested a review from chrisveilleux Sep 11, 2019
@davidwagnerkc

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Tested 👍

@davidwagnerkc davidwagnerkc merged commit f486528 into MycroftAI:dev Sep 18, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 53.236%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.