Catch exceptions when reloading skills #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicitly catch FileNotFoundError - Do a general catch and log for other exceptions
devs-mycroft
added
the
CLA: Yes
chrisveilleux
approved these changes
Sep 17, 2019
|
Tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
I've experienced a couple of halts of the skill manager due to FileNotFoundErrors when reloading skills.
This will explicitly
How to test
Make sure skill service is still loading and reloading as expected
Contributor license agreement signed?
CLA [ Yes ]