Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/adapt munging #2303

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@JarbasAl
Copy link
Contributor

commented Sep 13, 2019

Description

if a keyword contains the skill id there is a mismatch between registered keyword and keyword required by intents

depending on the name of the skill adapt keywords can get incorrectly munged when registering intent, this causes intents to be registered to a keyword without the skill id, while the keyword itself was correctly munged and contains the skill id

took me a while to understand why some intents magically would not trigger, until i renamed the skill and everything started working

How to test

register a keyword containing the skill_id

Contributor license agreement signed?

CLA [yes ] (Whether you have signed a CLA - Contributor Licensing Agreement

@forslund

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Works great, merging!

@forslund forslund merged commit b79a2a5 into MycroftAI:dev Sep 13, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 53.246%
Details
@JarbasAl JarbasAl deleted the JarbasAl:bugfix/adapt_munging branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.