Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status queries to the skill process #2304

Merged
merged 1 commit into from Sep 14, 2019

Conversation

forslund
Copy link
Collaborator

Description

mycroft.skills.is_alive: The service is started and priority skills are
loaded.
mycroft.skills.all_loaded: All skills on the system has been loaded.

How to test

Check the return of self.bus.wait_for_response(Message('mycroft.skills.is_alive')) and self.bus.wait_for_response(Message('mycroft.skills.all_loaded')) from a skill.

Contributor license agreement signed?

CLA [ Yes ]

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Sep 13, 2019
@forslund
Copy link
Collaborator Author

An alternative could be to have single mycroft.skills.status returning a data structure

{
  "priority_loaded": true,
  "all_loaded": true
}

mycroft.skills.is_alive: The service is started and priority skills are
loaded.
mycroft.skills.all_loaded: All skills on the system has been loaded.
Copy link
Contributor

@davidwagnerkc davidwagnerkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised 👍 Maybe we could move to your suggested mycroft.skills.status if we end up having more state like this that might need to be queried. For now with just these 2 key confirmations I think this is good.

@forslund
Copy link
Collaborator Author

Agreed. Merging

@forslund forslund merged commit accafee into MycroftAI:dev Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants