Handle HTTP errors when updating device attributes #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
Capture the correct exceptions when updating device version and enclosure type. Switches from BackendDown to ConnectionError and HTTPError.
forslund
force-pushed
the
bugfix/skill-startup-server-error
branch
from
7414b61
to
5457c26
Compare
forslund
changed the title
forslund
changed the title
chrisveilleux
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
If the backend throws an unexpected 500 error (or other status code indicating an error) the startup sequence would halt since the HTTPError isn't expected.
Capture the correct exceptions when updating device version and
enclosure type. Switches from BackendDown to ConnectionError and
HTTPError.
How to test
Ensure that the skill startup sequence doesn't halt.
Contributor license agreement signed?
CLA [ Yes ]