Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTP errors when updating device attributes #2306

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@forslund
Copy link
Member

commented Sep 16, 2019

Description

If the backend throws an unexpected 500 error (or other status code indicating an error) the startup sequence would halt since the HTTPError isn't expected.

Capture the correct exceptions when updating device version and
enclosure type. Switches from BackendDown to ConnectionError and
HTTPError.

How to test

Ensure that the skill startup sequence doesn't halt.

Contributor license agreement signed?

CLA [ Yes ]

@forslund forslund requested a review from chrisveilleux Sep 16, 2019
Capture the correct exceptions when updating device version and
enclosure type. Switches from BackendDown to ConnectionError and
HTTPError.
@forslund forslund force-pushed the forslund:bugfix/skill-startup-server-error branch from 7414b61 to 5457c26 Sep 16, 2019
@forslund forslund changed the title Handle errors when udating device attributes Handle errors when updating device attributes Sep 16, 2019
@forslund forslund changed the title Handle errors when updating device attributes Handle HTTP errors when updating device attributes Sep 16, 2019
@forslund forslund merged commit 65bc1b9 into MycroftAI:dev Sep 16, 2019
2 checks passed
2 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.