Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all exceptions from upload device info #2311

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@forslund
Copy link
Member

commented Sep 17, 2019

Description

Expands the HTTPError, Connection error capture to a general Exception

How to test

Make sure skills process starts

Contributor license agreement signed?

CLA [ Yes ]

@forslund forslund requested a review from krisgesling Sep 17, 2019
@forslund

This comment has been minimized.

Copy link
Member Author

commented Sep 17, 2019

Fairly simple change. Self-merging.

@forslund forslund merged commit fa6d826 into MycroftAI:dev Sep 17, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 53.243%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.