Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch all exceptions from upload device info #2311

Merged
merged 1 commit into from Sep 17, 2019
Merged

Catch all exceptions from upload device info #2311

merged 1 commit into from Sep 17, 2019

Conversation

forslund
Copy link
Collaborator

Description

Expands the HTTPError, Connection error capture to a general Exception

How to test

Make sure skills process starts

Contributor license agreement signed?

CLA [ Yes ]

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Sep 17, 2019
@forslund
Copy link
Collaborator Author

Fairly simple change. Self-merging.

@forslund forslund merged commit fa6d826 into MycroftAI:dev Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisgesling krisgesling

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@forslund @devs-mycroft