settingsMeta API call to be issued without a device ID in the URL. #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sMeta API call to be issued without a device ID in the URL.
devs-mycroft
added
the
CLA: Yes
|
Updated the test cases. The 405 is gone. Prepared PR #2313 which is a probable root cause for this issue. |
|
Oh, and Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Fix a bug where the settingsMeta API call was failing on initial boot if the device was paired but the device identity attribute of the API class did not yet know the device's ID
How to test
Boot an unpaired device. There should be no API calls with a URL of
v1/device//settingsMetathat fail with a 405 error.Contributor license agreement signed?
CLA [yes]