Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settingsMeta API call to be issued without a device ID in the URL. #2312

Merged
merged 2 commits into from Sep 18, 2019

Conversation

@chrisveilleux
Copy link
Member

commented Sep 17, 2019

Description

Fix a bug where the settingsMeta API call was failing on initial boot if the device was paired but the device identity attribute of the API class did not yet know the device's ID

How to test

Boot an unpaired device. There should be no API calls with a URL of v1/device//settingsMeta that fail with a 405 error.

Contributor license agreement signed?

CLA [yes]

…sMeta API call to be issued without a device ID in the URL.
@forslund

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

Updated the test cases. The 405 is gone. Prepared PR #2313 which is a probable root cause for this issue.

@forslund

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

Oh, and Merging!

@forslund forslund merged commit 35bf4c8 into dev Sep 18, 2019
3 checks passed
3 checks passed
:-) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 53.788%
Details
@forslund forslund deleted the bug/settingsmeta-upload-device-uuid branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.