New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "found_wakeword" event to message bus #2367
Conversation
|
Hello, @speedfox-uk, thank you for helping with the Mycroft project! We welcome everyone To protect yourself, the project, and users of Mycroft technologies we require Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank |
|
Hi This is working as expected...however it seems like the recognizer_loop:wakeword should mean the same thing. But that seem to be broken in some way. We should try to determine why the original message is late... |
|
It's broken because the message tone is played in the same method that does the wakeword detection (_wait_until_wake_word in mic.py). The other way to fix this would be to take playing the wakeword detected tone out of _wait_until_wake_word and put it somewhere after the wakeword message has been sent. Either that or remove the current "wakeword" message and just rename my new message to that. I don't mind either way. |
|
It's a bit more than that, (at least to me) it seems like it's not sent until after the recording of the STT phrase is complete... |
|
I do think it'd be best if your message was renamed but that would also require the session id to be included SessionManager.touch()
payload = {
'utterance': self.wakeword_recognizer.key_phrase,
'session': SessionManager.get().session_id,
}
self.emitter.emit("recognizer_loop:wakeword", payload)And the corresponding section in listener.py should be removed. |
|
OK, I'll make the change after I get home and update the PR. |
|
I've renamed it to "wakeword" and removed the old one. I'm just grabbing the utterance from "self.wake_word_name" rather than keeping a reference to the wakeword recogniser because it seemed like a simpler solution. |
|
Thanks, will look it over and hopefully merge tomorrow. |
|
@davidwagnerkc had done some similar work so I've assigned him to do the review of these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. This makes much more sense. Thanks for taking the time to get a PR up.
|
No problem. Just happy that this is making its way into master. |
The message is now emitted directly after a wakeword is detected.
|
Did a rebase to clean it up but merging now. Many thanks for fixing this! |
Description
Added an event to the message bus that will be sent when the wakeword
is found and before the notification sound is played
How to test
Connect to the message bus and output all of the messages. Say the wakeword. You should see the "found_wakeword" message,
Contributor license agreement signed?
Yes